Repository navigation
Run the RabbitMQ integration tests against a real broker - #221
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ndevenish
force-pushed
the
test-rabbitmq-broker
branch
from
November 6, 2026 16:38
58b104b to
dce283d
Compare
The pika transport tests that need a broker were always skipped, both locally and in CI, as nothing provided one. Add a session rabbitmq_broker fixture that uses, in order: RABBITMQ_HOST/RABBITMQ_PORT if set, an existing broker on localhost:5672, or a temporary rabbitmq:3 container started with docker or podman. If no broker can be found or started the tests are skipped locally, but fail when CI is set, so that they can't silently stop running again. Add a rabbitmq service to the GitHub Actions test job.
Resolves a CodeQL 'potentially uninitialized local variable' alert. The previous code was correct, as _no_broker() never returns, but CodeQL doesn't follow NoReturn.
ndevenish
force-pushed
the
test-rabbitmq-broker
branch
from
November 6, 2026 16:52
dce283d to
d9cacb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pika transport tests that need a broker were always skipped, both locally and in CI, as nothing provided one.
Add a session rabbitmq_broker fixture that uses, in order: RABBITMQ_HOST/RABBITMQ_PORT if set, an existing broker on localhost:5672, or a temporary rabbitmq:3 container started with docker or podman. If no broker can be found or started the tests are skipped locally, but fail when CI is set, so that they can't silently stop running again.
Add a rabbitmq service to the GitHub Actions test job.